Wasm dedup #49538
Merged
Wasm dedup #49538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…data about wrappers is not dedup-ed, so a separate dedup pass still saves more space.
vargaz
requested review from
CoffeeFlux,
EgorBo,
imhameed,
lambdageek,
marek-safar and
SamMonoRT
as code owners
|
Tagging subscribers to this area: @CoffeeFlux Issue Details
|
|
This saves about 100k on a hello world sample. |
…tances etc. multiple times. This works as follows: * Controlled by a new public 'WasmDedup' property, defaults to true. * All assemblies are AOT compiled with the 'dedup-skip' option, which causes the AOT compiler to avoid generating generic instances, certain wrappers etc. * A new internal assembly called aot-instances.dll is added to the build. * When aot-instances.dll is AOTed, all the other assemblies are AOTed together, but only the generic instances/wrappers are emitted into its AOT image.
lambdageek
approved these changes
Mar 12, 2021
|
This is 100k on the AOT hello world, right? |
|
Yes |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.